JAkutenshi commented on code in PR #4747:
URL: https://github.com/apache/ignite-3/pull/4747#discussion_r1853695422
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/disaster/GroupUpdateRequest.java:
##########
@@ -304,14 +304,19 @@ private static CompletableFuture<Integer> partitionUpdate(
Assignment nextAssignment =
nextAssignment(localPartitionStateMessageByNode, partAssignments);
+ boolean isNextEqualsToRestoredAsPlannedAssignments =
partAssignments.size() == 1 && partAssignments.contains(nextAssignment);
+
// There are nodes with data, and we set pending assignments to this
set of nodes. It'll be the source of peers for
// "resetPeers", and after that new assignments with restored replica
factor wil be picked up from planned assignments
// for the case of the manual update, that was triggered by a user.
Iif invokeClosure = prepareMsInvokeClosure(
partId,
longToBytesKeepingOrder(revision),
Assignments.forced(Set.of(nextAssignment),
assignmentsTimestamp).toBytes(),
- Assignments.toBytes(partAssignments, assignmentsTimestamp)
+ // In case if nodes set is equal then we shouldn't schedule
the same planned rebalance
Review Comment:
Old commentary, I guess the new one is more precise now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
