ptupitsyn commented on PR #4763: URL: https://github.com/apache/ignite-3/pull/4763#issuecomment-2493073151
> Maybe follow the factory pattern In this case, as a user, I would assume the following: * Factory returns a new object every time * The object "belongs" to this caller and no other caller sees it * I should release the resources when done None of that is correct. > Pool without returning to the pool is a bit confusing TBH I'm not sure, that's why I asked for your review :) Certainly less confusing than the factory that reuses objects. Maybe we should use a different name, like `IgniteClientGroup`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
