ptupitsyn commented on code in PR #4763: URL: https://github.com/apache/ignite-3/pull/4763#discussion_r1853405687
########## modules/platforms/dotnet/Apache.Ignite/IgniteClientPool.cs: ########## @@ -0,0 +1,162 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +namespace Apache.Ignite; + +using System; +using System.Diagnostics.CodeAnalysis; +using System.Linq; +using System.Threading; +using System.Threading.Tasks; +using Internal; +using Internal.Common; + +/// <summary> +/// Ignite client pool. Thread safe. +/// <para> +/// This pool creates up to <see cref="IgniteClientPoolConfiguration.Size"/> Ignite clients and returns them in a round-robin fashion. +/// Ignite clients are thread safe, so there is no rent/return semantics. +/// </para> +/// <example> +/// Register as a singleton in DI container: +/// <code> +/// builder.Services.AddSingleton(_ => new IgniteClientPool( +/// new IgniteClientPoolConfiguration +/// { +/// Size = 3, +/// ClientConfiguration = new("localhost"), +/// })); +/// </code> +/// Invoke from a controller: +/// <code> +/// public async Task<IActionResult> Index([FromServices] IgniteClientPool ignite) +/// { +/// var client = await ignite.GetClientAsync(); +/// var tables = await client.Tables.GetTablesAsync(); +/// return Ok(tables); +/// } +/// </code> +/// </example> +/// </summary> +public sealed class IgniteClientPool : IDisposable +{ + private readonly IgniteClientInternal?[] _clients; + + private readonly SemaphoreSlim _clientsLock = new(1); + + private int _disposed; + + private int _clientIndex; + + /// <summary> + /// Initializes a new instance of the <see cref="IgniteClientPool"/> class. + /// </summary> + /// <param name="configuration">Configuration.</param> + public IgniteClientPool(IgniteClientPoolConfiguration configuration) + { + IgniteArgumentCheck.NotNull(configuration); + IgniteArgumentCheck.NotNull(configuration.ClientConfiguration); + IgniteArgumentCheck.Ensure(configuration.Size > 0, nameof(configuration.Size), "Pool size must be positive."); + + Configuration = configuration; + _clients = new IgniteClientInternal[configuration.Size]; + } + + /// <summary> + /// Gets the configuration. + /// </summary> + public IgniteClientPoolConfiguration Configuration { get; } + + /// <summary> + /// Gets a value indicating whether the pool is disposed. + /// </summary> + public bool IsDisposed => Interlocked.CompareExchange(ref _disposed, 0, 0) == 1; + + /// <summary> + /// Gets an Ignite client from the pool. Creates a new one if necessary. + /// Performs round-robin balancing across pooled instances. + /// <para /> + /// NOTE: Do not dispose the client instance returned by this method, it is managed by the pool. + /// </summary> + /// <returns>Ignite client.</returns> + [SuppressMessage("Reliability", "CA2000:Dispose objects before losing scope", Justification = "Pooled.")] + public async ValueTask<IIgniteClient> GetClientAsync() + { + ObjectDisposedException.ThrowIf(IsDisposed, this); + + int index = Interlocked.Increment(ref _clientIndex) % _clients.Length; + + IgniteClientInternal? client = _clients[index]; + if (client is { IsDisposed: false }) Review Comment: Please elaborate. Yes, I understand that we can return a disposed client because some other thread closes it after this check, but there is no way to improve this situation, right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
