NSAmelchev commented on code in PR #11647:
URL: https://github.com/apache/ignite/pull/11647#discussion_r1853326128


##########
modules/core/src/main/java/org/apache/ignite/internal/client/thin/ClientClusterImpl.java:
##########
@@ -67,6 +72,15 @@ class ClientClusterImpl extends ClientClusterGroupImpl 
implements ClientCluster
                     }
 
                     req.out().writeByte((byte)newState.ordinal());
+
+                    if 
(protocolCtx.isFeatureSupported(ProtocolBitmaskFeature.FORCE_DEACTIVATION_FLAG))
 {
+                        req.out().writeBoolean(forceDeactivation);
+                    }
+                    else if (forceDeactivation) {

Review Comment:
   Fixed, thank you.



##########
modules/core/src/main/java/org/apache/ignite/client/ClientCluster.java:
##########
@@ -41,6 +42,19 @@ public interface ClientCluster extends ClientClusterGroup {
      */
     public void state(ClusterState newState) throws ClientException;
 
+    /**
+     * Changes current cluster state to given {@code newState} cluster state.
+     * <p>
+     * <b>NOTE:</b>
+     * Deactivation clears in-memory caches (without persistence) including 
the system caches.
+     *
+     * @param newState New cluster state.
+     * @param forceDeactivation If {@code true}, cluster deactivation will be 
forced.
+     * @throws ClientException If change state operation failed.
+     */
+    @IgniteExperimental
+    public void state(ClusterState newState, boolean forceDeactivation) throws 
ClientException;

Review Comment:
   Done.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to