nizhikov commented on code in PR #11647:
URL: https://github.com/apache/ignite/pull/11647#discussion_r1839811527
##########
modules/core/src/main/java/org/apache/ignite/internal/client/thin/ClientClusterImpl.java:
##########
@@ -67,6 +72,15 @@ class ClientClusterImpl extends ClientClusterGroupImpl
implements ClientCluster
}
req.out().writeByte((byte)newState.ordinal());
+
+ if
(protocolCtx.isFeatureSupported(ProtocolBitmaskFeature.FORCE_DEACTIVATION_FLAG))
{
+ req.out().writeBoolean(forceDeactivation);
+ }
+ else if (forceDeactivation) {
Review Comment:
This will break change state from new client to old servers:
`state(ClusterState newState)` always pass `true` and old server not support
`forceDeactivation`.
So, any change of cluster state from thin client will throw
`ClientFeatureNotSupportedByServerException`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
