AMashenkov commented on code in PR #4697:
URL: https://github.com/apache/ignite-3/pull/4697#discussion_r1841979730
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/mapping/MappingServiceImpl.java:
##########
@@ -220,7 +231,9 @@ private CompletableFuture<MappedFragments> mapFragments(
return res.thenApply(assignments -> {
Int2ObjectMap<ExecutionTarget> targetsById = new
Int2ObjectOpenHashMap<>();
- MappingContext context = new MappingContext(localNodeName, new
ArrayList<>(assignments.nodes()), template.cluster);
+ MappingContext context = new MappingContext(
+ localNodeName, new
ArrayList<>(assignments.nodes(nodeExclusionFilter)), template.cluster
Review Comment:
If we can't avoid copying, then the filter can be not null (@Nullable not
needed) and null value replaced with "always false" predicate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
