korlov42 opened a new pull request, #4697:
URL: https://github.com/apache/ignite-3/pull/4697

   https://issues.apache.org/jira/browse/IGNITE-22768
   
   This patch introduces recovery for the case when node on which fragment is 
mapped left the cluster before the moment of sending the fragment.
   
   To address the issue, the following has been done:
   - introduced `nodeExclusionFilter` to `MappingService`: nodes which meet the 
predicate must be excluded from the mapping. If one or more mandatory nodes 
were excluded, then generic `MappingException` will be thrown
   - changed `ExecutionService` interface: now `execute` method returns future 
that will be completed only after distributed query is completely initialized
   - `MessageService` now completes future returned from `send` with 
`UnknownNodeException` if recipient cannot be resolved (left the cluster or 
never exists)
   - introduced `Program`'s to query FSM, which includes error handle to 
recover from particular situations. See javadoc for details
   
   -----------
   
   Thank you for submitting the pull request.
   
   To streamline the review process of the patch and ensure better code quality
   we ask both an author and a reviewer to verify the following:
   
   ### The Review Checklist
   - [ ] **Formal criteria:** TC status, codestyle, mandatory documentation. 
Also make sure to complete the following:  
   \- There is a single JIRA ticket related to the pull request.  
   \- The web-link to the pull request is attached to the JIRA ticket.  
   \- The JIRA ticket has the Patch Available state.  
   \- The description of the JIRA ticket explains WHAT was made, WHY and HOW.  
   \- The pull request title is treated as the final commit message. The 
following pattern must be used: IGNITE-XXXX Change summary where XXXX - number 
of JIRA issue.
   - [ ] **Design:** new code conforms with the design principles of the 
components it is added to.
   - [ ] **Patch quality:** patch cannot be split into smaller pieces, its size 
must be reasonable.
   - [ ] **Code quality:** code is clean and readable, necessary developer 
documentation is added if needed.
   - [ ] **Tests code quality:** test set covers positive/negative scenarios, 
happy/edge cases. Tests are effective in terms of execution time and resources.
   
   ### Notes
   - [Apache Ignite Coding 
Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Java+Code+Style+Guide)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to