zstan commented on code in PR #4714:
URL: https://github.com/apache/ignite-3/pull/4714#discussion_r1840104134
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/fsm/ExecutionPhase.java:
##########
@@ -65,9 +47,4 @@ public enum ExecutionPhase {
Result evaluate(Query query) {
return handler.handle(query);
}
-
- /** Returns {@code true} if transition is allowed from current phase to
given one, return {@code false} otherwise. */
- boolean transitionAllowed(ExecutionPhase newPhase) {
Review Comment:
as i understand correct transitions is :
1. from previous to only next phase
2. from any, besides TERMINATED into any previous
3. from any into TERMINATED in case of errors
briefly ordinal of current phase in comparison with next can be incremented
only be 1 or TERMINATED or decrement by any. Why do you think that such a check
is redundant ? Or i miss smth ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
