korlov42 commented on code in PR #4714:
URL: https://github.com/apache/ignite-3/pull/4714#discussion_r1840119802
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/fsm/ExecutionPhase.java:
##########
@@ -65,9 +47,4 @@ public enum ExecutionPhase {
Result evaluate(Query query) {
return handler.handle(query);
}
-
- /** Returns {@code true} if transition is allowed from current phase to
given one, return {@code false} otherwise. */
- boolean transitionAllowed(ExecutionPhase newPhase) {
Review Comment:
possible transitions now defined by program (which is initialized with
collection of `Transition`'s object). The check is moved to Program as well
(see `org.apache.ignite.internal.sql.engine.exec.fsm.Program#advanceQuery`).
So, it's not up to ExecutionPhase whether transition is allowed or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
