J-Bakuli commented on code in PR #11637:
URL: https://github.com/apache/ignite/pull/11637#discussion_r1837985293
##########
modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ServerImpl.java:
##########
@@ -982,6 +987,43 @@ else if (!spi.failureDetectionTimeoutEnabled() && reconCnt
== spi.getReconnectCo
}
}
+ /**
+ * Pings the node by its address to see if it's alive.
+ *
+ * @param addr Address of the node.
+ * @param nodeId Node ID to ping. In case when client node ID is not null
this node ID is an ID of the router node.
+ * @param clientNodeId Client node ID.
+ * @param timeout Timeout on operation in milliseconds. If 0, a value
based on {@link TcpDiscoverySpi} is used.
+ * @param debugLogging Boolean flag indicating whether debug information
should be printed into node log.
+ * @return ID of the remote node and "client exists" flag if node alive or
{@code null} if the remote node has
+ * left a topology during the ping process.
+ * @throws IgniteCheckedException If an error occurs.
+ * @see #pingNodeImpl(InetSocketAddress, UUID, UUID, long, boolean)
+ */
+ @Nullable private IgniteBiTuple<UUID, Boolean> pingNode(
+ InetSocketAddress addr,
+ @Nullable UUID nodeId,
+ @Nullable UUID clientNodeId,
+ long timeout,
+ boolean debugLogging) throws IgniteCheckedException {
+ try {
+ return pingNodeImpl(addr, nodeId, clientNodeId, timeout,
debugLogging);
+ }
+ catch (IgniteCheckedException e) {
+ logPingError(e.getMessage(), debugLogging);
+
+ throw e;
+ }
+ }
Review Comment:
thank you, I agree
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
