vldpyatkov commented on code in PR #2537:
URL: https://github.com/apache/ignite-3/pull/2537#discussion_r1837005862
##########
modules/transactions/src/main/java/org/apache/ignite/internal/tx/impl/ReadWriteTransactionImpl.java:
##########
@@ -135,9 +140,24 @@ private void checkEnlistPossibility() {
}
}
- /** {@inheritDoc} */
@Override
- protected CompletableFuture<Void> finish(boolean commit) {
+ public CompletableFuture<Void> commitAsync() {
+ return TransactionsExceptionMapperUtil.convertToPublicFuture(
+ finish(true, nullableHybridTimestamp(NULL_HYBRID_TIMESTAMP),
false),
+ TX_COMMIT_ERR
+ );
+ }
+
+ @Override
+ public CompletableFuture<Void> rollbackAsync() {
+ return TransactionsExceptionMapperUtil.convertToPublicFuture(
+ finish(false, nullableHybridTimestamp(NULL_HYBRID_TIMESTAMP),
false),
+ TX_ROLLBACK_ERR
+ );
+ }
+
+ @Override
+ public CompletableFuture<Void> finish(boolean commit, HybridTimestamp
executionTimestamp, boolean full) {
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
