oleg-vlsk commented on code in PR #11425:
URL: https://github.com/apache/ignite/pull/11425#discussion_r1833671923


##########
modules/core/src/main/java/org/apache/ignite/internal/processors/query/running/RunningQueryManager.java:
##########
@@ -195,6 +213,11 @@ public RunningQueryManager(GridKernalContext ctx) {
             qryHistTracker.queryHistory().values(),
             SqlQueryHistoryView::new);
 
+        ctx.systemView().registerView(SQL_PLAN_HIST_VIEW, 
SQL_PLAN_HIST_VIEW_DESC,

Review Comment:
   I added `testResetPlanHistorySize()` and `testResetPlanHistoryMetrics()` to 
the `SqlPlanHistoryIntegrationTest` class to check that the view will function 
properly after we change either `planHistTracker` or 
`planHistTracker.sqlPlanHistory`. But it turned out that even when we pass a 
collection of data to `registerView()` the view works alright.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to