oleg-vlsk commented on code in PR #11425: URL: https://github.com/apache/ignite/pull/11425#discussion_r1774392956
########## modules/core/src/main/java/org/apache/ignite/internal/processors/query/running/SqlPlanHistoryTracker.java: ########## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.processors.query.running; + +import java.util.Collections; +import java.util.Map; +import org.apache.ignite.internal.util.GridBoundedConcurrentLinkedHashMap; + +/** Class that manages recording and storing SQL plans. */ +public class SqlPlanHistoryTracker { + /** SQL plan history. */ + private final GridBoundedConcurrentLinkedHashMap<SqlPlan, Long> sqlPlanHistory; + + /** SQL plan history size. */ + private int historySize; + + /** + * @param historySize SQL plan history size. + */ + public SqlPlanHistoryTracker(int historySize) { + this.historySize = historySize; + + sqlPlanHistory = (historySize > 0) ? new GridBoundedConcurrentLinkedHashMap<>(historySize) : null; + } + + /** + * @param plan SQL plan. + * @param qry Query. + * @param schema Schema name. + * @param loc Local query flag. + * @param engine SQL engine. + */ + public void addPlan(String plan, String qry, String schema, boolean loc, String engine) { + if (historySize <= 0) + return; + + SqlPlan sqlPlan = new SqlPlan(plan, qry, schema, loc, engine); + + sqlPlanHistory.put(sqlPlan, sqlPlan.startTime()); Review Comment: Yes, the key wasn't updated during the `put()` operation. To fix it, I changed the SQL plan history data structure from `GridBoundedConcurrentLinkedHashMap` to `GridBoundedConcurrentLinkedHashSet` and edited the `addPlan()` method, so that newer entries would replace older entries with the same SQL plan. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
