rpuch commented on code in PR #4642:
URL: https://github.com/apache/ignite-3/pull/4642#discussion_r1820788752


##########
modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/WatchProcessor.java:
##########
@@ -105,6 +106,13 @@ public interface EntryReader {
     /** Failure processor that is used to handle critical errors. */
     private final FailureManager failureManager;
 
+    /**
+     * Whether a failure in notification chain was passed to the 
FailureHandler. Used to make sure that we only pass first such a failure
+     * because, as any failure in the chain will stop any notifications, it 
only makes sense to log the first one. Subsequent ones will
+     * be instances of the same original exception.
+     */
+    private final AtomicBoolean firedFailureOnChain = new AtomicBoolean(false);

Review Comment:
   In this case it seems good to have it explicit



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to