tkalkirill commented on code in PR #4642:
URL: https://github.com/apache/ignite-3/pull/4642#discussion_r1820556491
##########
modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/WatchProcessor.java:
##########
@@ -341,11 +344,20 @@ public void advanceSafeTime(HybridTimestamp time) {
.thenRunAsync(() ->
watchEventHandlingCallback.onSafeTimeAdvanced(time), watchExecutor)
.whenComplete((ignored, e) -> {
if (e != null) {
- failureManager.process(new
FailureContext(CRITICAL_ERROR, e));
+
notifyFailureHandlerOnFirstFailureInNotificationChain(e);
}
});
}
+ private void
notifyFailureHandlerOnFirstFailureInNotificationChain(Throwable e) {
+ if (firedFailureOnChain.compareAndSet(false, true)) {
Review Comment:
Maybe we should use a different `failureManager` by default, then the
problem will go away on its own, it looks like a solution that won't be needed
later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
