Vladsz83 commented on code in PR #11606:
URL: https://github.com/apache/ignite/pull/11606#discussion_r1814950839
##########
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/type/IgniteTypeFactory.java:
##########
@@ -315,7 +316,7 @@ public RelDataType createCustomType(Type type) {
public RelDataType createCustomType(Type type, boolean nullable) {
if (UUID.class == type)
return canonize(new UuidType(nullable));
- else if (Object.class == type)
+ else if (Object.class == type || (type instanceof Class &&
BinaryObject.class.isAssignableFrom((Class<?>)type)))
Review Comment:
I think we can't get any problem here. Calcite expects a class in
`createType(Type type)`:
`if (!(type instanceof Class)) {
throw new UnsupportedOperationException("TODO: implement " + type);
}
final Class clazz = (Class) type;`
An `assert` looks enough to me. Up to you,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
