alex-plekhanov commented on code in PR #11606:
URL: https://github.com/apache/ignite/pull/11606#discussion_r1810611568
##########
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/type/IgniteTypeFactory.java:
##########
@@ -315,7 +316,7 @@ public RelDataType createCustomType(Type type) {
public RelDataType createCustomType(Type type, boolean nullable) {
if (UUID.class == type)
return canonize(new UuidType(nullable));
- else if (Object.class == type)
+ else if (Object.class == type || (type instanceof Class &&
BinaryObject.class.isAssignableFrom((Class<?>)type)))
return canonize(new OtherType(nullable));
Review Comment:
It canonized by `DATATYPE_CACHE.intern` and always return the same instance
for `OtherType`. Why do you think it does nothing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
