korlov42 commented on code in PR #4584: URL: https://github.com/apache/ignite-3/pull/4584#discussion_r1808250420
########## modules/sql-engine/src/integrationTest/sql/types/char/test_char.test: ########## @@ -6,26 +6,24 @@ query T rowsort SELECT ' prefix' || c1 || 'trailing ' FROM (VALUES('1 '::CHAR(5)), (' 2'::CHAR(5)), (''::CHAR(5)), (null)) t(c1); ---- - prefix 2 trailing - prefix1 trailing - prefix trailing + prefix 2trailing + prefix1 trailing Review Comment: We agreed to consider CHAR type as alias to VARCHAR. This means Ignite will never be compliant with PG when dealing with CHAR type. Current behavior (with missing right padding) closer to what we agreed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org