korlov42 commented on code in PR #4584: URL: https://github.com/apache/ignite-3/pull/4584#discussion_r1808244346
########## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/exec/coercion/CharacterStringComparisonExecutionTest.java: ########## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.sql.engine.exec.coercion; + +import org.apache.ignite.internal.sql.engine.planner.datatypes.utils.CharacterStringPair; +import org.junit.jupiter.params.ParameterizedTest; +import org.junit.jupiter.params.provider.EnumSource; + +/** Check execution results for numeric comparisons. */ +public class CharacterStringComparisonExecutionTest extends BaseTypeCheckExecutionTest { + @ParameterizedTest + @EnumSource + public void comparisonEq(CharacterStringPair typePair) throws Exception { + try (ClusterWrapper testCluster = testCluster(typePair, dataProvider(typePair))) { + testCluster.process("SELECT c1 = c2 FROM t", checkReturnResult()); + } + } + + @ParameterizedTest + @EnumSource + public void comparisonLessEq(CharacterStringPair typePair) throws Exception { + try (ClusterWrapper testCluster = testCluster(typePair, dataProvider(typePair))) { + testCluster.process("SELECT c1 <= c2 FROM t", checkReturnResult()); + } + } + + @ParameterizedTest + @EnumSource + public void comparisonGreatEq(CharacterStringPair typePair) throws Exception { + try (ClusterWrapper testCluster = testCluster(typePair, dataProvider(typePair))) { + testCluster.process("SELECT c1 >= c2 FROM t", checkReturnResult()); + } + } + + @ParameterizedTest + @EnumSource + public void comparisonLess(CharacterStringPair typePair) throws Exception { + try (ClusterWrapper testCluster = testCluster(typePair, dataProvider(typePair))) { + testCluster.process("SELECT c1 < c2 FROM t", checkReturnResult()); + } + } + + @ParameterizedTest + @EnumSource + public void comparisonGreat(CharacterStringPair typePair) throws Exception { + try (ClusterWrapper testCluster = testCluster(typePair, dataProvider(typePair))) { + testCluster.process("SELECT c1 < c2 FROM t", checkReturnResult()); Review Comment: nice catch! Fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
