Re: [PR] IGNITE-23172 Sql. Lack of bounds validation in CAST(1 as DECIMAL(MAX_PREC, MAX_SCALE)) [ignite-3]

[via GitHub]

xtern commented on code in PR #4566:
URL: https://github.com/apache/ignite-3/pull/4566#discussion_r1803035393


##########
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/planner/datatypes/NumericCaseTypeCoercionTest.java:
##########
@@ -51,7 +50,7 @@
 public class NumericCaseTypeCoercionTest extends BaseTypeCoercionTest {
     private static final IgniteSchema SCHEMA = 
createSchemaWithTwoColumnTable(NativeTypes.STRING, NativeTypes.STRING);
 
-    private static final NativeType DECIMAL_MAX_PREC = 
NativeTypes.decimalOf(MAX_DECIMAL_PRECISION, 0);
+    private static final NativeType DECIMAL_DYN_PARAM_DEFAULT = 
NativeTypes.decimalOf(28, 6);

Review Comment:
   why not use `DECIMAL_DYNAMIC_PARAM_PRECISION` and 
`DECIMAL_DYNAMIC_PARAM_SCALE` constants?
   I mean
   ```
   NativeTypes.decimalOf(DECIMAL_DYNAMIC_PARAM_PRECISION, 
DECIMAL_DYNAMIC_PARAM_SCALE);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org