ygerzhedovich commented on code in PR #4566:
URL: https://github.com/apache/ignite-3/pull/4566#discussion_r1801342639
##########
modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItDynamicParameterTest.java:
##########
@@ -92,6 +96,45 @@ void testMetadataTypesForDynamicParameters(ColumnType type) {
assertQuery("SELECT
?").withParams(param).returns(param).columnMetadata(new
MetadataMatcher().type(type)).check();
}
+ /**
+ * By default derived type of parameter of type BigDecimal is DECIMAL(28,
6). This test makes sure it's possible to go beyond
+ * default precision and scale by wrapping dynamic param placeholder with
CAST operation.
+ */
+ @ParameterizedTest
+ @ValueSource(ints = {30, 60, 120})
Review Comment:
let's also check values less than default, like a 10, 20
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
