ivanzlenko commented on code in PR #4530:
URL: https://github.com/apache/ignite-3/pull/4530#discussion_r1800586475
##########
modules/metastorage/src/testFixtures/java/org/apache/ignite/internal/metastorage/server/AbstractKeyValueStorageTest.java:
##########
@@ -42,6 +43,11 @@ public void tearDown() throws Exception {
storage.close();
}
+ /** Creates a Meta Storage context based on a timestamp. Index and term
will be {@code 0}. */
+ protected static KeyValueUpdateContext msContext(HybridTimestamp
timestamp) {
+ return new KeyValueUpdateContext(0, 0, timestamp);
Review Comment:
We already have such test-only method with awkward placement and using it
half the time. It is just looks very inconsistent.
##########
modules/metastorage/src/test/java/org/apache/ignite/internal/metastorage/server/SimpleInMemoryCompactionKeyValueStorageTest.java:
##########
@@ -23,4 +23,9 @@ public class SimpleInMemoryCompactionKeyValueStorageTest
extends AbstractCompact
public KeyValueStorage createStorage() {
return new SimpleInMemoryKeyValueStorage("test");
}
+
+ @Override
+ public void testSaveCompactionRevisionAndRestart() {
Review Comment:
It can be package-private.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
