ibessonov commented on code in PR #4530:
URL: https://github.com/apache/ignite-3/pull/4530#discussion_r1800582118
##########
modules/metastorage/src/testFixtures/java/org/apache/ignite/internal/metastorage/server/AbstractKeyValueStorageTest.java:
##########
@@ -42,6 +43,11 @@ public void tearDown() throws Exception {
storage.close();
}
+ /** Creates a Meta Storage context based on a timestamp. Index and term
will be {@code 0}. */
+ protected static KeyValueUpdateContext msContext(HybridTimestamp
timestamp) {
+ return new KeyValueUpdateContext(0, 0, timestamp);
Review Comment:
I'm not a big fan of creating test-only methods in production classes.
What's the benefit?
If you imply that I should put it into some test fixtures, then please be
more specific. This is such a simple method that I don't really care about the
fact that it's present multiple times.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
