xtern commented on code in PR #4409:
URL: https://github.com/apache/ignite-3/pull/4409#discussion_r1775321352
##########
modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItDataTypesTest.java:
##########
@@ -513,9 +448,6 @@ public void testDecimalLiteral() {
assertQuery("SELECT DECIMAL '10.000' * DECIMAL '0.01'").returns(new
BigDecimal(("0.10000"))).check();
assertQuery("SELECT DECIMAL '10.000' / DECIMAL '0.01'").returns(new
BigDecimal(("1000.0"))).check();
- assertQuery("SELECT DECIMAL '10.000' =
'10.000'").returns(true).check();
- assertQuery("SELECT DECIMAL '10.000' =
'10.001'").returns(false).check();
Review Comment:
maybe it's worth keeping these cases, but comparing the literal with the
numeric value? :thinking:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
