korlov42 commented on code in PR #4409: URL: https://github.com/apache/ignite-3/pull/4409#discussion_r1773160591
########## modules/sql-engine/src/integrationTest/sql/types/date/test_date.test_ignore: ########## @@ -1,73 +0,0 @@ -# name: test/sql/types/date/test_date.test -# description: Test basic DATE functionality -# group: [date] -# Ignore https://issues.apache.org/jira/browse/IGNITE-15619 -# Note: these tests fail because AI3 does not allow <datetime> +/- <number> arithmetic. -# According to the standard only <datetime> +/- <interval> arithmetic is allowed. - -statement ok -PRAGMA enable_verification - -# create and insert into table -statement ok -CREATE TABLE dates(i DATE) - -statement ok -INSERT INTO dates VALUES ('1993-08-14'), (NULL) - -# check that we can select dates -query T -SELECT * FROM dates ----- -1993-08-14 -NULL - -# YEAR function -query I -SELECT year(i) FROM dates ----- -1993 -NULL - -# check that we can convert dates to string -query T -SELECT cast(i AS VARCHAR) FROM dates ----- -1993-08-14 -NULL - -# check that we can add days to a date -query T -SELECT i + 5 FROM dates ----- -1993-08-19 -NULL - -# check that we can subtract days from a date -query T -SELECT i - 5 FROM dates Review Comment: Why do we need tests adding up date and integer? Arithmetic between date and intervals is covered in `sql/types/interval` tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
