Vladsz83 commented on code in PR #11495:
URL: https://github.com/apache/ignite/pull/11495#discussion_r1765037516
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotCheckProcess.java:
##########
@@ -369,19 +381,9 @@ private void reducePreparationAndMetasCheck(
}
}
- /** Finds current snapshot name from the metas. */
- private @Nullable String snpName(Map<UUID, SnapshotCheckResponse> results)
{
- for (SnapshotCheckResponse nodeRes : results.values()) {
- if (nodeRes == null || F.isEmpty(nodeRes.metas))
- continue;
-
- assert nodeRes.metas.get(0) != null : "Empty snapshot metadata in
the results";
- assert !F.isEmpty(nodeRes.metas.get(0).snapshotName()) : "Empty
snapshot name in a snapshot metadata.";
-
- return nodeRes.metas.get(0).snapshotName();
- }
-
- return null;
+ /** @return Unique operation context id depending on request type and
snapshot name. */
+ private static String contextId(SnapshotCheckProcessRequest req) {
Review Comment:
Ok. But that woul decline concurrent: restoring snapshot and checking
incremental, checking different increments of the same snapshot, quick check
and full check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
