timoninmaxim commented on code in PR #11495:
URL: https://github.com/apache/ignite/pull/11495#discussion_r1759753300


##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotChecker.java:
##########
@@ -872,4 +1277,78 @@ private SnapshotEncryptionKeyProvider(GridKernalContext 
ctx, Map<Integer, File>
             return key != null && key.id() == keyId ? key : null;
         }
     }
+
+    /**  */
+    public static class IncrementalSnapshotResult implements Serializable {

Review Comment:
   public static nested classes are bad practice. It looks like we can just use 
existing class IncrementalSnapshotVerificationTaskResult.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to