korlov42 commented on code in PR #2443:
URL: https://github.com/apache/ignite-3/pull/2443#discussion_r1300983655


##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/rel/set/IgniteReduceIntersect.java:
##########
@@ -34,55 +34,68 @@
  * Physical node for REDUCE phase of INTERSECT operator.
  */
 public class IgniteReduceIntersect extends IgniteIntersect implements 
IgniteReduceSetOp {
+
+    private final int inputsNum;

Review Comment:
   well, the truth is we don't care about intermediate operators, because they 
either are not changing row type -- then deduction will be correct, -- or plan 
is not correct at all, since reduce node is expecting rows to be in exact 
format defined by its MAP counterpart.
   
   Seems like both `IgniteReduceIntersect` and `IgniteReduceMinus` should have 
`aggregateFieldsCount` implemented like 
   ```
       public int aggregateFieldsCount() {
           return getInput(0).getRowType().getFieldCount();
       }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to