lowka commented on code in PR #2443:
URL: https://github.com/apache/ignite-3/pull/2443#discussion_r1299612130
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/rel/set/IgniteMapSetOp.java:
##########
@@ -66,6 +68,32 @@ default RelDataType buildRowType() {
return builder.build();
}
+ /**
+ * Creates a row type produced by MAP phase of INTERSECT/EXCEPT operator.
+ * For input row (a:type1, b:type2) and {@code inputsNum} = {@code 3} it
produces the following row type:
+ * <pre>
+ * f0: type1
+ * f1: type2
+ * _count_0: int
+ * _count_1: int
+ * _count_2: int
+ * </pre>
+ */
+ public static RelDataType buildRowType(IgniteTypeFactory typeFactory,
RelDataType rowType, int inputsNum) {
Review Comment:
>I'd expect to see row layout in javadoc to AbstractSetOpNode.
Each operator has different structure for intermediate rows. There are
descriptions of how both operator work (see subclasses of Grouping), that
description includes row structure.
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/rel/set/IgniteMapSetOp.java:
##########
@@ -66,6 +68,32 @@ default RelDataType buildRowType() {
return builder.build();
}
+ /**
+ * Creates a row type produced by MAP phase of INTERSECT/EXCEPT operator.
+ * For input row (a:type1, b:type2) and {@code inputsNum} = {@code 3} it
produces the following row type:
+ * <pre>
+ * f0: type1
+ * f1: type2
+ * _count_0: int
+ * _count_1: int
+ * _count_2: int
+ * </pre>
+ */
+ public static RelDataType buildRowType(IgniteTypeFactory typeFactory,
RelDataType rowType, int inputsNum) {
Review Comment:
>I'd expect to see row layout in javadoc to AbstractSetOpNode.
Each operator has different structure for intermediate rows. There are
descriptions of how both operator work (see subclasses of Grouping), that
descriptions include row structures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
