AMashenkov commented on code in PR #2443:
URL: https://github.com/apache/ignite-3/pull/2443#discussion_r1298666652
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/rel/set/IgniteReduceIntersect.java:
##########
@@ -96,4 +103,5 @@ public <T> T accept(IgniteRelVisitor<T> visitor) {
public int aggregateFieldsCount() {
return rowType.getFieldCount() + 2 /* At least two fields required for
count aggregation. */;
Review Comment:
Is this calculation still actual?
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/rel/set/IgniteReduceIntersect.java:
##########
@@ -96,4 +103,5 @@ public <T> T accept(IgniteRelVisitor<T> visitor) {
public int aggregateFieldsCount() {
return rowType.getFieldCount() + 2 /* At least two fields required for
count aggregation. */;
}
+
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
