AMashenkov commented on code in PR #2443:
URL: https://github.com/apache/ignite-3/pull/2443#discussion_r1298645702
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/rel/set/IgniteReduceIntersect.java:
##########
@@ -34,55 +34,68 @@
* Physical node for REDUCE phase of INTERSECT operator.
*/
public class IgniteReduceIntersect extends IgniteIntersect implements
IgniteReduceSetOp {
+
+ private final int inputsNum;
+
/**
* Constructor.
- * TODO Documentation https://issues.apache.org/jira/browse/IGNITE-15859
+ *
+ * @param cluster Cluster that this relational expression belongs to.
+ * @param traitSet The traits of this rel.
+ * @param input Input relational expression.
+ * @param all Whether this operator should return all rows or only
distinct rows.
+ * @param rowType Row type this expression produces.
*/
public IgniteReduceIntersect(
RelOptCluster cluster,
RelTraitSet traitSet,
RelNode input,
boolean all,
- RelDataType rowType
+ RelDataType rowType,
Review Comment:
It looks like we don't need to pass rowType from outside, as it should be
constructed at first call
`getRowType() -> deriveRowType() -> buildRowType()`
I can't understand, why we initialize protected field below `this.rowType =
rowType`, which prevents rowType from building (see call chain I mention
before), and therefore makes `IgniteMapSetOp.buildRowType()` method totally
useless....
Seems, the original rowType was passed just for correct
`aggregateFieldsCount()`... or I missed smth?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
