zstan commented on code in PR #2441:
URL: https://github.com/apache/ignite-3/pull/2441#discussion_r1294562337
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ExecutionServiceImpl.java:
##########
@@ -796,6 +802,9 @@ public IgniteRel visit(IgniteTableScan rel) {
@Override
public IgniteRel visit(IgniteTableModify rel) {
int tableId =
rel.getTable().unwrap(IgniteTable.class).id();
+
+ // TODO IGNITE-19499 Remove rewriting tableId.
+ tableId = deps.internalTable(tableId).tableId();
List<NodeWithTerm> assignments =
fragment.mapping().updatingTableAssignments();
enlist(tableId, assignments);
Review Comment:
ok, i just want to say that we can obtain NPE here is some circumstances, we
need assert check or some upper checks here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
