AMashenkov commented on code in PR #2441:
URL: https://github.com/apache/ignite-3/pull/2441#discussion_r1293374732
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ExecutionDependencyResolverImpl.java:
##########
@@ -81,8 +81,10 @@ public IgniteRel visit(IgniteTableScan rel) {
private void resolveTable(IgniteTable igniteTable) {
int tableId = igniteTable.id();
TableDescriptor tableDescriptor = igniteTable.descriptor();
+ //TODO IGNITE-19499 Use id instead of name.
+ String tableName = igniteTable.name();
- tableMap.computeIfAbsent(tableId, (id) ->
registry.getTable(tableId, tableDescriptor));
+ tableMap.computeIfAbsent(tableId, (id) ->
registry.getTable(schemaVersion, tableId, tableName, tableDescriptor));
Review Comment:
We need schemaVersion to get table from cache inside the `registry`.
TableDescriptor contains no id, and no schemaVersion.
Maybe we have to rethink, how tables are resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
