AMashenkov commented on code in PR #2286:
URL: https://github.com/apache/ignite-3/pull/2286#discussion_r1269527921
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java:
##########
@@ -1276,18 +1282,22 @@ private CompletableFuture<?> createTableLocally(
pendingTables.put(tableId, table);
startedTables.put(tableId, table);
- tablesById(causalityToken).thenAccept(ignored -> inBusyLock(busyLock,
() -> {
+ createPartsFut.thenAccept(ignored -> inBusyLock(busyLock, () -> {
pendingTables.remove(tableId);
}));
- tablesById(causalityToken)
- .thenRun(() -> inBusyLock(busyLock, () ->
completeApiCreateFuture(table)));
+ createPartsFut
+ .thenRunAsync(() -> inBusyLock(busyLock, () ->
completeApiCreateFuture(table)));
Review Comment:
What a thread pool should we use to complete user futures?
Why we should execute user stuff (other user futures, which may be chained
to the current one) in a system thread pool?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
