AMashenkov commented on code in PR #2286:
URL: https://github.com/apache/ignite-3/pull/2286#discussion_r1269509091
##########
modules/distribution-zones/src/test/java/org/apache/ignite/internal/distributionzones/BaseDistributionZoneManagerTest.java:
##########
@@ -126,6 +126,7 @@ void setUp() {
distributionZoneManager = new DistributionZoneManager(
zonesConfiguration,
tablesConfiguration,
+ DistributionZonesTestUtil.mockCatalog(),
Review Comment:
I think we shouldn't mock catalog the way we do.
Instead I'd create a test implementation, which allow us to check if
component subscribes to some events,
and allow us to trigger any event directly (without any mocking internal
stuff like metastorage).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
