tkalkirill commented on code in PR #2200:
URL: https://github.com/apache/ignite-3/pull/2200#discussion_r1232189383
##########
modules/storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/ColumnFamilyUtils.java:
##########
@@ -92,6 +90,10 @@ public static ColumnFamilyType fromCfName(String cfName) {
}
}
+ public static String stringName(byte[] cfName) {
Review Comment:
Missing javadoc, I think a more appropriate name `toStingName`
##########
modules/storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/instance/SharedRocksDbInstanceCreator.java:
##########
@@ -189,7 +188,7 @@ private List<ColumnFamilyDescriptor>
getExistingCfDescriptors(Path path) throws
@SuppressWarnings("resource")
private ColumnFamilyOptions createCfOptions(byte[] cfName, Path path) {
- var utf8cfName = new String(cfName, UTF_8);
+ String utf8cfName = ColumnFamilyUtils.stringName(cfName);
Review Comment:
Use static import
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
