ibessonov commented on code in PR #2200:
URL: https://github.com/apache/ignite-3/pull/2200#discussion_r1232166136
##########
modules/storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/RocksDbStorageEngine.java:
##########
@@ -170,14 +173,18 @@ public RocksDbTableStorage createMvTable(
assert dataRegion != null : "tableId=" + tableId + ", dataRegion=" +
tableDescriptor.getDataRegion();
- Path tablePath = storagePath.resolve(TABLE_DIR_PREFIX + tableId);
-
- try {
- Files.createDirectories(tablePath);
- } catch (IOException e) {
- throw new StorageException("Failed to create table store directory
for table: " + tableId, e);
- }
+ SharedRocksDbInstance sharedInstance =
sharedInstances.computeIfAbsent(tableDescriptor.getDataRegion(), name -> {
Review Comment:
We should revisit this whole data region thing in rocksdb anyway, I think
I'll create a JIRA for it
EDIT: https://issues.apache.org/jira/browse/IGNITE-19762
We'll figure it out later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
