xdn-code opened a new pull request, #4420:
URL: https://github.com/apache/hertzbeat/pull/4420

   ## Summary
   
   Hi @MuAnswer and @orangeCatDeveloper, thank you for reporting this and for 
the clear root-cause analysis.
   
   This change follows the suggested direction of scheduling in milliseconds:
   
   - Keep the remaining cyclic delay in milliseconds instead of truncating with 
`intervalMs / 1000`
   - Schedule cyclic jobs with `TimeUnit.MILLISECONDS`
   - Use a 100ms wheel tick so millisecond delays are not collapsed back to 
whole seconds
   - Honor the `timeUnit` argument in `cyclicJob(...)`
   
   ## Test plan
   
   - [x] `TimerDispatcherTest`
   - [x] Added `testIntervalDispatchPreservesMillisecondRemainder` for the 30s 
/ 300ms case
   
   Please let me know if anything should be adjusted. Thanks again.
   
   Fixes #2405
   
   
   Made with [Cursor](https://cursor.com)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to