xdn-code opened a new pull request, #4419: URL: https://github.com/apache/hertzbeat/pull/4419
## Summary Hi @StreamPlume, thank you for the careful investigation and the clear report in #4400. This PR follows your findings and proposed direction. - Tolerate a null `fileKey()` on Windows in `StandaloneDeploymentOwner` and `SecureSetupFileLock` by falling back to a canonical-path identity. - Preserve the underlying `IOException` cause, retry lock reopen against transient Windows AV/indexer deny-share handles, and re-enforce owner-only DACLs on existing lock files. - Expand `OwnerOnlyFilePermissions` with `WRITE_ACL` and related rights so the ACL can repair itself. - Add diagnostics on the migration preflight path so lock/identity failures are no longer silently turned into `recovery_required`. ## Test plan - [x] `StandaloneDeploymentOwnerTest` - [x] `SecureSetupFileLockTest` - [x] `OwnerOnlyFilePermissionsTest` - [x] `ManagedMigrationStartupRecoverySessionTest` - [x] `StartupFailureReporterTest` - [ ] Verify standalone startup on Windows 11 / NTFS (would be very grateful if you can help confirm this on your machine) Thank you again for tracing this so thoroughly. Feedback is very welcome. Fixes #4400 Made with [Cursor](https://cursor.com) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
