zqr10159 commented on PR #4396: URL: https://github.com/apache/hertzbeat/pull/4396#issuecomment-5906910348
Thanks @hutiefang76. I approved the workflows, and CI found a test-configuration isolation issue on 3152edc. The PostgreSQL regression itself passes (1 test, 0 failures/errors/skips), but the startup suite fails with 31 errors. The nested PostgresqlJpaConfiguration is annotated with @Configuration, so HertzBeatApplication's broad @ComponentScan discovers it during other tests. Its @EnableJpaRepositories then registers the AI repositories again, causing BeanDefinitionOverrideException (for example, sopScheduleDao and chatMessageDao). Could you isolate this configuration from application component scanning? One minimal option is to remove its @Configuration annotation and unused import, keeping the @Bean methods and @Enable* annotations: it is already explicitly registered with AnnotationConfigApplicationContext(PostgresqlJpaConfiguration.class), which supports lite configuration processing. Please verify this with both the PostgreSQL regression and the full startup test suite. Replacing it with @TestConfiguration alone may not be sufficient here because the application's explicit @ComponentScan does not include Boot's TypeExcludeFilter. CI logs: https://github.com/apache/hertzbeat/actions/runs/36684533679/job/109792678176 The transaction fix looks reasonable, but let's resolve this test isolation failure and get CI green before merging. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
