Copilot commented on code in PR #4119:
URL: https://github.com/apache/hertzbeat/pull/4119#discussion_r3083505665
##########
script/ci/github-actions/setup-deps/action.yml:
##########
@@ -26,15 +26,28 @@ runs:
with:
distribution: "zulu"
java-version: 25
+ cache: maven
+
+ - name: Cache mvnd
+ id: mvnd-cache
+ uses: actions/cache@v4
+ with:
+ path: ~/.local/mvnd
+ key: ${{ runner.os }}-${{ runner.arch }}-mvnd-2.0.0-rc-3
- name: Install mvnd
+ if: steps.mvnd-cache.outputs.cache-hit != 'true'
shell: bash
run: |
MVND_VERSION=2.0.0-rc-3
curl -sL
https://dlcdn.apache.org/maven/mvnd/${MVND_VERSION}/maven-mvnd-${MVND_VERSION}-linux-amd64.zip
-o mvnd.zip
unzip -q mvnd.zip
mkdir -p $HOME/.local
mv maven-mvnd-${MVND_VERSION}-linux-amd64 $HOME/.local/mvnd
Review Comment:
The mvnd download/extract is hard-coded to the `linux-amd64` distribution
(`...-linux-amd64.zip` / `maven-mvnd-...-linux-amd64`), but the cache key
includes `${{ runner.arch }}`. If this composite action ever runs on ARM64 (or
non-Linux), it will download the wrong binary and/or fail to find the extracted
directory. Consider selecting the mvnd artifact based on
`runner.os`/`runner.arch` (or explicitly fail fast when unsupported) and
keeping the cache key aligned with the selected artifact.
##########
.github/workflows/nightly-build.yml:
##########
@@ -43,10 +52,8 @@ jobs:
- name: Build the Backend
run: |
- mvn clean install
- mvn clean package -Prelease -DskipTests
- cd hertzbeat-collector
- mvn clean package -Pcluster -DskipTests
+ mvnd -B clean install -Prelease -DskipTests
+ mvnd -B -f hertzbeat-collector/hertzbeat-collector-collector/pom.xml
package -Pcluster -DskipTests
Review Comment:
This changes the nightly backend build from running tests (`mvn clean
install` previously) to skipping them (`-DskipTests` on the `clean install`
invocation). That’s a functional coverage change and seems to conflict with the
PR description (“keeps the existing workflow coverage intact”). Either restore
test execution here or update the PR description / workflow intent to reflect
that nightly no longer runs backend tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
