No-SilverBullet commented on code in PR #2858:
URL: https://github.com/apache/dubbo-go/pull/2858#discussion_r2081824509
##########
common/constant/key.go:
##########
@@ -64,6 +64,16 @@ const (
MaxServerRecvMsgSize = "max-server-recv-msg-size"
KeepAliveInterval = "keep-alive-interval"
KeepAliveTimeout = "keep-alive-timeout"
+
+ // TODO: remove IDLMode after old triple removed
+ IDLMode = "IDL-mode"
+)
+
+// TODO: remove this after old triple removed
+// IDLMode
+const (
+ IDL = "IDL"
+ NONIDL = "non-IDL"
Review Comment:
change to an enumerated type for better type safety, like
`type IDLMode string`
`const (`
` // IDLModeIDL represents the IDL mode of Triple protocol`
` IDLModeIDL IDLMode = "IDL"`
` // IDLModeNonIDL represents the non-IDL mode of Triple protocol`
` IDLModeNonIDL IDLMode = "non-IDL"`
`)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
