Copilot commented on code in PR #2858:
URL: https://github.com/apache/dubbo-go/pull/2858#discussion_r2094553391
##########
global/reference_config.go:
##########
@@ -47,6 +47,10 @@ type ReferenceConfig struct {
MeshProviderPort int `yaml:"mesh-provider-port"
json:"mesh-provider-port,omitempty" propertiy:"mesh-provider-port"`
KeepAliveInterval string `yaml:"keep-alive-interval"
json:"keep-alive-interval,omitempty" property:"keep-alive-interval"`
KeepAliveTimeout string `yaml:"keep-alive-timeout"
json:"keep-alive-timeout,omitempty" property:"keep-alive-timeout"`
+
+ // just for new triple non-IDL mode
+ // TODO: remove IDLMode when config package is removed
+ IDLMode string
Review Comment:
The new `IDLMode` field lacks YAML/JSON tags, so it won't be deserialized
from config files. Add tags such as `yaml:"idl-mode" json:"idl-mode,omitempty"`.
```suggestion
IDLMode string `yaml:"idl-mode" json:"idl-mode,omitempty"`
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
