marsevilspirit commented on code in PR #2858:
URL: https://github.com/apache/dubbo-go/pull/2858#discussion_r2072402787
##########
protocol/triple/server.go:
##########
@@ -76,9 +76,13 @@ func (s *Server) Start(invoker protocol.Invoker, info
*common.ServiceInfo) {
serialization := URL.GetParam(constant.SerializationKey,
constant.ProtobufSerialization)
switch serialization {
case constant.ProtobufSerialization:
+ logger.Debugf("Triple server use protobuf serializaition")
case constant.JSONSerialization:
+ logger.Debugf("Triple server use json serializaition")
case constant.Hessian2Serialization:
+ logger.Debugf("Triple server use hessian2 serializaition")
case constant.MsgpackSerialization:
+ logger.Debugf("Triple server use msgpack serializaition")
Review Comment:
fixed
##########
protocol/triple/client.go:
##########
@@ -157,12 +158,16 @@ func newClientManager(url *common.URL) (*clientManager,
error) {
switch serialization {
case constant.ProtobufSerialization:
isIDL = true
+ logger.Debugf("Triple client manager use protobuf
serializaition")
case constant.JSONSerialization:
isIDL = true
+ logger.Debugf("Triple client manager use protojson
serializaition")
cliOpts = append(cliOpts, tri.WithProtoJSON())
case constant.Hessian2Serialization:
+ logger.Debugf("Triple client manager use hessian2
serializaition")
cliOpts = append(cliOpts, tri.WithHessian2())
case constant.MsgpackSerialization:
+ logger.Debugf("Triple client manager use msgpack
serializaition")
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
