CrazyHZM commented on code in PR #15113:
URL: https://github.com/apache/dubbo/pull/15113#discussion_r1949300591
##########
dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/deploy/DefaultApplicationDeployer.java:
##########
@@ -989,21 +989,21 @@ private DynamicConfiguration getDynamicConfiguration(URL
connectionURL) {
*/
private final AtomicInteger serviceRefreshState = new AtomicInteger(0);
- private void registerServiceInstance() {
- try {
- registered = true;
+ public synchronized void registerServiceInstance() {
Review Comment:
`checkState` already uses synchronized, so consider deleting it here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
