BitoAgent commented on code in PR #13786:
URL: https://github.com/apache/dubbo/pull/13786#discussion_r1544735346
##########
dubbo-common/src/main/java/org/apache/dubbo/config/AbstractInterfaceConfig.java:
##########
@@ -441,7 +441,7 @@
}
protected MethodConfig getMethodByName(String name) {
- if (methods != null && methods.size() > 0) {
+ if (methods != null && !methods.isEmpty()) {
Review Comment:
**Scalability Issue**: Using '!methods.isEmpty()' is more readable and
idiomatic than checking 'methods.size() > 0'. <br> **Fix**: Replace the
condition 'methods.size() > 0' with '!methods.isEmpty()' for better
readability. <br> **Code Suggestion**:
```
- if (methods != null && methods.size() > 0) {
+ if (methods != null && !methods.isEmpty()) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
