BitoAgent commented on code in PR #13786:
URL: https://github.com/apache/dubbo/pull/13786#discussion_r1544735341
##########
dubbo-common/src/main/java/org/apache/dubbo/config/AbstractInterfaceConfig.java:
##########
@@ -420,7 +420,7 @@
}
private ArgumentConfig getArgumentByIndex(MethodConfig methodConfig, int
argIndex) {
- if (methodConfig.getArguments() != null &&
methodConfig.getArguments().size() > 0) {
+ if (methodConfig.getArguments() != null &&
!methodConfig.getArguments().isEmpty()) {
Review Comment:
**Suggestion**: Simplifying the condition to use
'!methodConfig.getArguments().isEmpty()' enhances readability. Good change.
<br> **Code Suggestion**:
```
The provided code change is appropriate and requires no further adjustments.
```
##########
dubbo-common/src/main/java/org/apache/dubbo/config/AbstractInterfaceConfig.java:
##########
@@ -441,7 +441,7 @@
}
protected MethodConfig getMethodByName(String name) {
- if (methods != null && methods.size() > 0) {
+ if (methods != null && !methods.isEmpty()) {
Review Comment:
**Suggestion**: Using '!methods.isEmpty()' instead of 'methods.size() > 0'
for checking if the list is not empty is more readable and idiomatic. <br>
**Code Suggestion**:
```
The change correctly implements the suggested improvement.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
