DMwangnima commented on code in PR #2437:
URL: https://github.com/apache/dubbo-go/pull/2437#discussion_r1349492134
##########
registry/zookeeper/service_discovery.go:
##########
@@ -64,17 +64,18 @@ type zookeeperServiceDiscovery struct {
// newZookeeperServiceDiscovery the constructor of newZookeeperServiceDiscovery
func newZookeeperServiceDiscovery(url *common.URL) (registry.ServiceDiscovery,
error) {
+ rp := url.GetParam(constant.ZookeeperRootPath, rootPath)
Review Comment:
My bad, I did not describe it well. I thought you were going to add a
generic feature. Using **RegistryConfig.Params** could work.
**ZookeeperRootPath** should be "zookeeper.rootPath" like keys related to
nacos(https://github.com/apache/dubbo-go/blob/5ac057d3ca6c3c0ea1fa355c6dcdf64a0813c6b9/common/constant/key.go#L246).
Maybe we should add comments on **RegistryConfig.Params** since it is not
intuitive to other users if there is no document explaining it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
