xiaomiusa87 commented on code in PR #2437:
URL: https://github.com/apache/dubbo-go/pull/2437#discussion_r1349451635
##########
registry/zookeeper/service_discovery.go:
##########
@@ -64,17 +64,18 @@ type zookeeperServiceDiscovery struct {
// newZookeeperServiceDiscovery the constructor of newZookeeperServiceDiscovery
func newZookeeperServiceDiscovery(url *common.URL) (registry.ServiceDiscovery,
error) {
+ rp := url.GetParam(constant.ZookeeperRootPath, rootPath)
Review Comment:
I have looked at the source code of Dubbo Java, and rootPath is only related
to the registryCenter ZookeeperServiceDiscovery
RootPath is only used during ZookeeperServiceDiscovery initialization, and
providers and consumers do not care about this param
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
