DaWesen commented on code in PR #3695:
URL: https://github.com/apache/dubbo-go/pull/3695#discussion_r3852738297
##########
filter/adaptivesvc/limiter/hill_climbing.go:
##########
@@ -20,12 +20,11 @@ package limiter
import (
"math"
"sync"
- "sync/atomic"
"time"
)
import (
- uberatomic "go.uber.org/atomic"
+ "go.uber.org/atomic"
Review Comment:
Agreed. This code already existed before this PR with the plain
"go.uber.org/atomic" import (no alias). Earlier commits in this PR had replaced
it with "sync/atomic" (plus hand-written wrappers) and later introduced the
uberatomic alias, but per review feedback we reverted the file to its original
state (matching upstream). So the import stays as-is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
